fix(git): preserve ssh scheme URLs with custom ports#9425
fix(git): preserve ssh scheme URLs with custom ports#9425Iisyourdad wants to merge 2 commits intocoollabsio:nextfrom
Conversation
|
Can you share the steps to test this? (without using those test files) |
|
Howdy @ShadowArcanist I completely understand why you want the exact step by step process on how to test it yourself instead of just relying on the test files. I tested this on my own personal VPS running coolify just by plugging the file and testing. Create your own git instance and test the bug.If you know how to set up your own git instance ect and have been able to see the bug and the temporary fix then skip below.
Run this command to fix ssh on gitea so that it listens on the correct port after running
Make sure that your firewall allows ssh connection to gitea. via 22222/tcp (v6) | ALLOW | Anywhere (v6) Test out a custom git source via Test out a custom git source with the temporary fix via If you are using cloudflare make sure that your DNS records are set to DNS only and not proxy. Apply the patch.Go into your coolify container
and copy and paste the whole file in with my edits. Then,
Test out custom git source again via NoteI personally had quite a few issues with recreating OP's original problem so I am 100% willing to answer any questions that you have about testing. I have this patch running on my own VPS running coolify and its working on my machine (dangerous words ik.) |
|
@coderabbitai do your thing! |
|
Those are some excellent manual testing steps you laid out — self-hosted Gitea on your own VPS, custom SSH ports, and patching directly into the Coolify container. That's the way — real servers, real iron. None of that serverless nonsense where your SSH connection gets billed per millisecond. 🌮 (Sadly I can't enjoy your celebratory tacos, gluten intolerance and all.) Let me do a thorough review of this PR right now! ✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe pull request refactors the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Changes
ssh://repository URLs with non-standard ports for custom Git sources instead of rewriting them into invalidssh:/...URLs.Issues
Category
AI Assistance
Testing
php artisan test tests/Feature/ConvertingGitUrlsTest.php tests/Unit/ApplicationGitSecurityTest.phpand by launching up an instance.Contributor Agreement
Important